clear lot of tickets

functions/src/notifications.js

@@ -2,7 +2,6 @@ const {
   onDocumentCreated,
   onDocumentWritten,
 } = require("firebase-functions/v2/firestore");
-const admin = require("firebase-admin");
 const { FieldValue } = require("firebase-admin/firestore");
 const { refList, ALERT_TYPE } = require("../index");
 const { Expo } = require("expo-server-sdk");
@@ -10,11 +9,12 @@ const { Resend } = require("resend");
 const { basicTemplate } = require("../helpers/email");
 const { RESEND_API_KEY } = require("../config/keys");
 
-const resendInstance = new Resend(RESEND_API_KEY);
+const resendInstance = RESEND_API_KEY ? new Resend(RESEND_API_KEY) : null;
 
 // Initialisation de Expo SDK
 let expo = new Expo();
 const EMAIL_FROM = "MusicLand <musicland@minuit.app>";
+const DEFAULT_EMAIL_TITLE = "MusicLand";
 
 function getCollectionRef(collectionName = "") {
   const ref = refList?.[collectionName];
@@ -24,6 +24,49 @@ function getCollectionRef(collectionName = "") {
   return ref;
 }
 
+function cleanString(value) {
+  return typeof value === "string" && value.trim() ? value.trim() : null;
+}
+
+function buildNotificationEmailPayload({
+  title = "",
+  message = "",
+  template = {},
+} = {}) {
+  const fallbackTitle = cleanString(title) || DEFAULT_EMAIL_TITLE;
+  const fallbackContent = cleanString(message) || "";
+  const overrides = template && typeof template === "object" ? template : {};
+
+  const subject = cleanString(overrides.subject) || fallbackTitle;
+  const emailTitle = cleanString(overrides.title) || fallbackTitle;
+  const content = cleanString(overrides.content) || fallbackContent;
+
+  let button = null;
+  if (overrides.button && typeof overrides.button === "object") {
+    const buttonUrl =
+      cleanString(overrides.button.url) || cleanString(overrides.button.href);
+    if (buttonUrl) {
+      button = {
+        url: buttonUrl,
+        label:
+          cleanString(overrides.button.label) ||
+          cleanString(overrides.button.text) ||
+          undefined,
+      };
+    }
+  }
+
+  const templatePayload = { title: emailTitle, content };
+  if (button) {
+    templatePayload.button = button;
+  }
+
+  return {
+    subject,
+    html: basicTemplate(templatePayload),
+  };
+}
+
 exports.sendNotificationWhenDocIsCreated = onDocumentCreated(
   { region: "europe-west1", document: "notifications/{notificationId}" },
   async (event) => {
@@ -49,52 +92,63 @@ exports.sendNotificationWhenDocIsCreated = onDocumentCreated(
       const {
         pushToken = null,
         pushTokens = [],
-        email = "",
+        email: receiverEmail = "",
         emailNotifications = false,
       } = receiverData;
 
       if (!mailOnly) {
-        const tokensSet = new Set(
-          []
-            .concat(Array.isArray(pushTokens) ? pushTokens : [])
-            .concat(pushToken ? [pushToken] : [])
-            .filter(Boolean),
-        );
-        const tokens = Array.from(tokensSet);
-
-        if (!tokens?.length) {
-          console.warn("User push token not found");
-          return null;
-        }
-
-        await sendExpoNotification({
-          tokens,
-          receiverId: receiver,
-          receiverCollection,
-          title: title || "MusicLand",
-          message: message,
-          data: notifData || {},
-        });
-      }
-      if (emailNotifications && !!email) {
         try {
-          if (!email) {
-            throw new Error("userMail is required");
+          const tokensSet = new Set(
+            []
+              .concat(Array.isArray(pushTokens) ? pushTokens : [])
+              .concat(pushToken ? [pushToken] : [])
+              .filter(Boolean),
+          );
+          const tokens = Array.from(tokensSet);
+
+          if (!tokens?.length) {
+            await sendExpoNotification({
+              tokens,
+              receiverId: receiver,
+              receiverCollection,
+              title: title || "MusicLand",
+              message: message,
+              data: notifData || {},
+            });
+          } else {
+            console.log("User push token not found");
           }
-          if (!email?.subject || !email?.html) {
-            throw new Error("Email subject and html are required");
-          }
-          await resendInstance.emails.send({
-            from: EMAIL_FROM,
-            to: [email],
-            subject: title,
-            html: basicTemplate({ title, content: message }),
-          });
         } catch (e) {
-          console.log("Error sending email:", e);
+          console.log("Error sending notif:", e);
+        }
+      }
+
+      if ((emailNotifications || mailOnly) && !!receiverEmail) {
+        if (!resendInstance) {
+          console.warn(
+            "Resend client not configured; unable to send notification email.",
+          );
+        } else {
+          try {
+            const { subject, html } = buildNotificationEmailPayload({
+              title,
+              message,
+              template: notifData?.email,
+            });
+            await resendInstance.emails.send({
+              from: EMAIL_FROM,
+              to: [receiverEmail],
+              subject,
+              html,
+            });
+          } catch (e) {
+            console.log("Error sending email:", e);
+          }
         }
       } else {
-        console.log(`Email disabled for user ${receiver} and type ${type}`);
+        console.log(
+          `[sendNotificationWhenDocIsCreated] Email not sent (${receiverEmail ? "user preference" : "missing email"}) for user ${receiver} and type ${notifData?.type || "UNKNOWN"}`,
+        );
       }
     } catch (e) {
       console.log(e);